#235: upgrade rusoto and force http1 for rustls #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jychen7
commented
Jan 1, 2023
| rusoto_s3 = { version = "0.47", default-features = false } | ||
| rusoto_credential = { version = "0.47" } | ||
| rusoto_sts = { version = "0.47", default-features = false } | ||
| rusoto_core = { version = "0.48", default-features = false } |
There was a problem hiding this comment.
need upgrade and use same version, Cargo.lock at main contains both versions: 0.48 and 0.47.
Lines 606 to 609 in c0bff95
Lines 1069 to 1072 in c0bff95
ELSE two versions point to different hyper-rustls (0.23.0 vs 0.22.1), Rust compile complains about the type
note: struct `HttpsConnector` and struct `hyper_rustls::connector::HttpsConnector` have similar names, but are actually distinct types
note: struct `HttpsConnector` is defined in crate `hyper_rustls`
--> /Users/******/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-rustls-0.23.0/src/connector.rs:20:1
|
20 | pub struct HttpsConnector<T> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: struct `hyper_rustls::connector::HttpsConnector` is defined in crate `hyper_rustls`
--> /Users/******/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-rustls-0.22.1/src/connector.rs:21:1
houqp
approved these changes
Jan 1, 2023
|
Thank you @jychen7 ! |
|
welcome :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
close #235
What
disable http2 and use http1 only for S3 like API
For reviewers
tested locally, but sorry, didn't add an integration test with mock S3/GCS container yet, seems more effort required