-
Notifications
You must be signed in to change notification settings - Fork 691
Global.push_context_set is always strict:true #19620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkySkimmer
added a commit
to SkySkimmer/coq-elpi
that referenced
this pull request
Oct 1, 2024
SkySkimmer
added a commit
to SkySkimmer/Coq-Equations
that referenced
this pull request
Oct 1, 2024
SkySkimmer
added a commit
to SkySkimmer/MetaRocq
that referenced
this pull request
Oct 1, 2024
SkySkimmer
added a commit
to rocq-community/rocq-lean-import
that referenced
this pull request
Oct 1, 2024
SkySkimmer
added a commit
to SkySkimmer/Mtac2
that referenced
this pull request
Oct 1, 2024
SkySkimmer
added a commit
to SkySkimmer/rewriter
that referenced
this pull request
Oct 1, 2024
SkySkimmer
added a commit
to SkySkimmer/coq-waterproof
that referenced
this pull request
Oct 1, 2024
Safe_typing.push_context_set has 1 occurrence of strict:false, in Vernacentries.vernac_global_check, so I didn't change it.
b5d4e95
to
37ab821
Compare
ppedrot
approved these changes
Oct 11, 2024
@coqbot merge now |
@ppedrot: You cannot merge this PR because:
|
@coqbot merge now |
@ppedrot: Please take care of the following overlays:
|
ppedrot
added a commit
to MetaRocq/metarocq
that referenced
this pull request
Oct 14, 2024
Adapt to rocq-prover/rocq#19620 (Global.push_context_set no strict argument)
ppedrot
added a commit
to mattam82/Coq-Equations
that referenced
this pull request
Oct 14, 2024
Adapt to rocq-prover/rocq#19620 (Global.push_context_set no strict argument)
jim-portegies
pushed a commit
to impermeable/coq-waterproof
that referenced
this pull request
Oct 14, 2024
Janno
added a commit
to Mtac2/Mtac2
that referenced
this pull request
Oct 14, 2024
Adapt to rocq-prover/rocq#19620 (Global.push_context_set no strict argument)
SkySkimmer
added a commit
to rocq-community/rocq-lean-import
that referenced
this pull request
Oct 14, 2024
Adapt to rocq-prover/rocq#19620 (Global.push_context_set no strict argument)
gares
added a commit
to LPCIC/coq-elpi
that referenced
this pull request
Oct 14, 2024
Adapt to rocq-prover/rocq#19620 (Global.push_context_set no strict argument)
JasonGross
pushed a commit
to SkySkimmer/rewriter
that referenced
this pull request
Oct 15, 2024
JasonGross
pushed a commit
to mit-plv/rewriter
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safe_typing.push_context_set has 1 occurrence of strict:false, in Vernacentries.vernac_global_check, so I didn't change it.
Overlays: