feat: update templates to use url_for function for asset links #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert hardcoded CSS, JS, RSS, JSON, and image links to use url_for function - Use set statements with slugify filters for dynamic feed URLs - Add proper whitespace control to template set statements - Update stream titles to use stream_display_name function - Ensure consistent URL generation across all template files This improves URL handling and makes the templates more maintainable by centralizing URL generation through the url_for function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #264
Relates #263
Summary
Update HTML template files to use the
url_forfunction instead of hardcoded asset links for better URL handling and maintainability.Changes
./static/*.cssto{{url_for(path='static/*.css')}}./static/*.jsto{{url_for(path='static/*.js')}}{% set %}statements with slugify filters thenurl_forwith string concatenationstatic/avatar-placeholder.pngto{{url_for(path='static/avatar-placeholder.png')}}stream_display_name(stream=stream)function for proper display names{%-and-%}to template set statementsFiles Modified
example/templates/base.html: Major updates to CSS, JS, RSS, and JSON feed linksexample/templates/content_authors.html: Avatar placeholder image linkexample/templates/group_author_avatar.html: Avatar placeholder image linkTechnical Details
~concatenation operator with proper syntaxThis change centralizes URL generation through the
url_forfunction, making the templates more maintainable and ensuring consistent URL handling throughout the application.