fix: prevent media file links from being converted to HTML links #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add media file extension detection to fix_internal_links function - Skip HTML conversion for links ending with media file extensions - Support comprehensive list of media formats: images, videos, audio, documents, and archives - Add comprehensive test coverage for media file link preservation - Preserve existing behavior for internal page links Fixes #281 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes relative links to media files being incorrectly converted to HTML links.
[View Image](/media/image.webp)are now preserved correctly[About](about.md)still convert toabout.htmlas expectedChanges
fix_internal_links()function insrc/parser.rsTest Plan
Testing
The fix was tested with the exact scenario from the issue:
Before: Generated incorrect link
media-homecloudpart1-mikrotik-webp.htmlAfter: Preserves correct link
/media/homecloudpart1-mikrotik.webpCloses #281
🤖 Generated with Claude Code