Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @osantana in #257, adding a
--https
config option.Mostly for semantic reasons, I suggested keeping
Marmite.https
asOption<bool>
instead ofbool
: this avoids a sort of incoherent state whereurl == "https://my.site"
whilehttps == false
.However I haven't implemented checks for other possible inconsistency (user can use
--url https://my.site and --https false
and in this case thehttps
is ignored). This bit relies on the added docs (the help message for--https
explicitly says it is used only if protocol is missing in the URL).The changes in
content.rs
andsite.rs
are unrelated but suggested bycargo clippy
— happy to revert, but I kept them since they are part of the contributing guide.