fix(python): use abi-14 since this is the max py-tree-sitter supports. #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix python bindings to just work with 'pip install'. Add a failing test that would have indicated the issue in CI. Test python bindings against ABI 14 and publish ABI 14 wheels in pypi.
There was a problem hiding this comment.
Pull Request Overview
This PR ensures Python bindings use the highest supported Tree-sitter ABI (14) by updating tests and CI/CD workflows.
- Refactors
test_binding.pyto use the public Tree-sitter Python API, introduces a helper, and adds tests that would fail on unsupported ABI. - Switches
Makefileto allow environment overrides forTREE_SITTER_ABI_VERSION. - Updates GitHub workflows to publish ABI 14 wheels, disable the default Python test until support exists, and add a dedicated “ABI 14” CI job.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| bindings/python/tests/test_binding.py | Use Language/Parser imports, add language() helper, new tests |
| Makefile | Change ABI version assignment to conditional (?=) |
| .github/workflows/publish.yml | Publish Python wheels with ABI 14 and enable generation |
| .github/workflows/ci.yml | Disable default Python CI, add matrix job for ABI 14 testing |
Comments suppressed due to low confidence (3)
bindings/python/tests/test_binding.py:8
- [nitpick] The helper function name
languageis very generic and may clash with built-ins; consider renaming it to something more descriptive likeget_javadoc_language.
def language():
bindings/python/tests/test_binding.py:14
- This test does not have an assertion or use the result; consider asserting the returned object is a
Languageinstance to validate grammar loading.
_ = language()
.github/workflows/ci.yml:76
- The
macos-15label is not a valid GitHub Actions runner; consider usingmacos-latestor a supported version such asmacos-12.
os: [ubuntu-latest, windows-latest, macos-15]
| parser = Parser(language()) | ||
| doc = "/** test */".encode() | ||
| tree = parser.parse(doc) | ||
| assert not tree.root_node.has_error |
There was a problem hiding this comment.
Use self.assertFalse(tree.root_node.has_error, 'Parsing errors detected') instead of a bare assert to leverage unittest assertion methods and provide a clearer failure message.
Suggested change
| assert not tree.root_node.has_error | |
| self.assertFalse(tree.root_node.has_error, 'Parsing errors detected') |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix python bindings to just work with 'pip install'.
Add a failing test that would have indicated the issue in CI.
Test python bindings against ABI 14 and publish ABI 14 wheels in pypi.