Add support of mulitple languages #13
Conversation
e411f1d to
345cafb
Compare
|
oops...CI seems to be broken |
There was a problem hiding this comment.
Hi! Wow this is a lot of work, so thanks again! I tried it locally and it seems to work good, have you tried the online locally? I haven't quite got around to it yet because I've been busy with school and other work but I'll try to get to it soon.
As for the other quotes, do you know how well something like google translate would work because it would be pretty easy to write a script for it but I don't know how good the quotes will translate.
Also what do you mean by writing a parser for it? Maybe if it is a better way to do it I could try to help out!
| -- FIXME :) | ||
| _ -> undefined |
There was a problem hiding this comment.
This is supposed to be undefined since the other cases aren't supposed to happen. Do you mean there should be a better way to represent it?
There was a problem hiding this comment.
I agree, just don't feel like it's a good thing to leave undefined somewhere in code. Maybe replace it with `error "Error: unexpected game state"?
There was a problem hiding this comment.
Ah okay fair enough, that makes sense!
Hmm it seems like the error is the same as this one. Maybe I will have to find another way to do linting or remove it entirely. |
Yes, it seems to work, but you'd better check it out once more :)
Pretty awfully, unfortunately, it would be around 60% +- ok quality with one-sentence quotes, but with number of sentences the quality drops significantly due to slang, names, etc, I don't think that translating the quotes is an option.
I mean to write a web crawler, which would go through any livelib stuff or citaty.info and collect quotes from them. Generally the problem is how to sort the good quotes from the err... cringy ones. Maybe the good strategy would be to gather links with good books in one place, run parser on them, replace unprintable on default layout symbols like ( What about haskell source code quotes, I'm not so sure, cause it's almost no difference what to type to me, and as I see it, it's to have 2-3 quotes from different projects repos, and the number of these quotes in the dataset doesn't matter much. What are your thoughts about that? |
Oh okay, I see what you mean. That seems like a pretty good way to do it, especially for many different quotes!
Yeah, honestly it doesn't make much of a difference to me either so I think that it's good enough to just have a few like you said. |
There was a problem hiding this comment.
Hi, just a few more things I ran into while testing the server!
When you try to enter a name or room with a 'q' in it, it just quits instead of entering it as text. I think that it would be easier to just reserve 'ESC' for quitting instead of having multiple bindings for it.
Also, when the client first joins the game, I don't think that the quote set is properly updated for them:
Other than that, the online functionality looks pretty good to me! :)
Yes, I also noticed this bug and fixed it, you probably didn't pull last changes at 51c96e3
Fixed :) |
Oops, my bad! |
|
It's okay, no problem at all! |
Hey! I added support of Russian and Haskell as alternative languages.
There are not really many quotes, because I didn't manage to find a decent dataset with russian quotes and that's annoying :c , and I kinda don't want to write a parser for that purpose yet (it's a bit difficult to filter good quotes), so I manually added some of them, gonna spend 30 min per day to add new ones for a month or so, I think having around ~500 of them would be nice for the start. Although I may give up and write a parser in the end...