Skip to content

Wake up waiting getChunk getter goroutines on Close, close getter quit channel #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2015
Merged

Wake up waiting getChunk getter goroutines on Close, close getter quit channel #73

merged 1 commit into from
Sep 26, 2015

Conversation

cce
Copy link
Contributor

@cce cce commented Sep 26, 2015

This seems to prevent a goroutine leak after closing an S3 reader. I found that after reading and closing several S3 files, there was a goroutine left for each waiting in (*getter).getChunk on g.cond.Wait().

@rlmcpherson
Copy link
Owner

Thanks, LGTM.

rlmcpherson added a commit that referenced this pull request Sep 26, 2015
@rlmcpherson
Merge pull request #73 from cce/stop-getter-worker-leak
38a6b34 
Wake up waiting getChunk getter goroutines on Close, close getter quit channel
@rlmcpherson rlmcpherson merged commit 38a6b34 into rlmcpherson:master Sep 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cce @rlmcpherson