Rust 1.57 compatibility #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sympathetic to keeping your MSRV at 1.57. I'll merge this PR now and see if there are any other issues that arise from pinning rkyv to 1.57. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to improve our support for rkyv in chrono (chronotope/chrono#959), and things are getting complicated because there is no dependency resolution for our minimum MSRV of 1.57.
As I currently see it the easiest (maybe only) solution would be if there was one 0.6.x version of bytecheck (and bytecheck_derive as its dependency) that can compile with Rust 1.57.
Would you be okay with making such a release?