Skip to content

build: provide rime.pdb when MSVC build #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2024
Merged

build: provide rime.pdb when MSVC build #909

merged 1 commit into from
Jul 3, 2024

Conversation

fxliang
Copy link
Contributor

@fxliang fxliang commented Jul 2, 2024

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@fxliang fxliang requested review from lotem and eagleoflqj July 2, 2024 13:56
eagleoflqj
eagleoflqj approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

% file rime.pdb 
rime.pdb: MSVC program database ver 7.00, 4096*8793 bytes

@eagleoflqj eagleoflqj merged commit cc332cc into rime:master Jul 3, 2024
@fxliang fxliang deleted the pdb branch July 3, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lotem lotem lotem approved these changes

@eagleoflqj eagleoflqj eagleoflqj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fxliang @lotem @eagleoflqj