Skip to content

fix deleting current candidate #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2024
Merged

fix deleting current candidate #906

merged 2 commits into from
Jul 4, 2024

Conversation

eagleoflqj
Copy link
Member

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

As in practice when both

DeleteCandidate(size_t index)

and

DeleteCandidate(std::optional<size_t> index)

exists, DeleteCandidate({}) is translated to DeleteCandidate(0) at least for clang on macOS. 🌚

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@eagleoflqj eagleoflqj requested a review from ksqsf June 30, 2024 04:55
@lotem
Copy link
Member

lotem commented Jun 30, 2024 •
edited
Loading

I find it clearer to keep DeleteCurrentSelection() and DeleteCandidate(size_t index) separate.

ksqsf
ksqsf approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fsck C++

@eagleoflqj eagleoflqj requested a review from lotem June 30, 2024 14:22
@lotem lotem merged commit 76dd707 into master Jul 4, 2024
@lotem lotem deleted the fix-delete branch July 4, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lotem lotem lotem approved these changes

@ksqsf ksqsf ksqsf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eagleoflqj @lotem @ksqsf