Skip to content

Conversation

WhiredPlanck
Copy link
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes # N/A

Feature

Describe feature of pull request

The build config of rime_table_decompiler didn't comply with the specification like other tools, and leads to build failure on Android.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

The build config of rime_table_decompiler didn't comply with the specification like other tools, and leads to build failure on Android.
@lotem
Copy link
Member

lotem commented Mar 17, 2024

I think this is the right change to do, but currently there are build failures:

  1. the docker build is caused by the previous change in rime/librime-charcode. I filed a separate bug error: 'ntohs' was not declared in this scope librime-charcode#5
  2. rime_table_decompiler failed its Windows builds because a lot of referenced code in dict module are not DLL exported. I prefer not to export those symbols because it'll make the changeset too large and I fear it'll decrease the efficiency of the compiled code with less opportunity for optimization.

Iet's do this instead:

  1. skip building rime_table_decompiler on Windows;
  2. (maybe after this PR) update the cmake config to allow building rime_table_decompiler on Windows by linking librime as a static library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants