Skip to content

Conversation

eagleoflqj
Copy link
Member

@eagleoflqj eagleoflqj commented Sep 3, 2023

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Before: release CI for 9e91418
boost's locale isn't built under Apple Clang 14.
Screenshot from 2023-09-03 19-29-36

After: release CI for 37d6e92
boost's locale is built under Homebrew Clang 16.
Screenshot from 2023-09-03 19-32-54

These behaviors are the same in my local macOS x64 13.5.1

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@eagleoflqj eagleoflqj merged commit 26ae8aa into rime:master Sep 3, 2023
@eagleoflqj eagleoflqj deleted the macos-release branch September 3, 2023 23:36
groverlynn pushed a commit to groverlynn/librime that referenced this pull request Sep 27, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant