Skip to content

Conversation

Bambooin
Copy link
Contributor

Pull request

This verison is verified in Trime(osfans/trime#1646) about three months ago, no issue found.

Due to boost release in GitHub was split to *.cmake and *.b2, so we use the
boost official release in https://www.boost.org/releases/latest/

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

This verison is verified in Trime(osfans/trime#1646) about three months ago, no issue found.

Due to boost release in GitHub was split to *.cmake and *.b2, so we use the
boost official release in https://www.boost.org/releases/latest/
@LEOYoon-Tsaw
Copy link
Member

Why changing boost download path?

@Bambooin
Copy link
Contributor Author

The GitHub release had split the download artifactory to two parts which we can use it anymore.

According the maillist in [1], the current official download site the behind the CDN which is faster.

  1. https://lists.boost.org/archives/list/boost@lists.boost.org/message/OALSRZIRNKIDEMUITUAUWCJRJUXPEZID/
  2. Boost Downloads boostorg/boost#924

Copy link
Member

@lotem lotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@lotem lotem merged commit 73890c5 into rime:master Jul 14, 2025
10 checks passed
@Bambooin Bambooin deleted the boost branch July 16, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants