ci: fix wrong filter on push event #1041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The forked repo non main branch won't trigger workflow, is hard for preparing pull request on non main branch in forked repo. First of all, we should trigger push event on any branch, the current filter is wrong, which won't trigger workflow on **forked repo** push event. The grammar is wrong by the document: https://docs.github.com/en/actions/how-tos/writing-workflows/choosing-when-your-workflow-runs/triggering-a-workflow#example-including-and-excluding-branches > If you define a branch with the ! character, you must also define at least one branch without the ! character. If you only want to exclude branches, use branches-ignore instead. Secondly, the main branch should trigger commit build in case of merge or rebase with pull requests.
lotem
approved these changes
Jul 12, 2025
|
Thanks. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
The forked repo non main branch won't trigger workflow, is hard for
preparing pull request on non main branch in forked repo.
First of all, we should trigger push event on any branch, the current
filter is wrong, which won't trigger workflow on forked repo push event.
The grammar is wrong by the document: https://docs.github.com/en/actions/how-tos/writing-workflows/choosing-when-your-workflow-runs/triggering-a-workflow#example-including-and-excluding-branches
Secondly, the main branch should trigger commit build in case of merge or rebase
with pull requests.
Feature
Describe feature of pull request
Unit test
Manual test
Code Review
Additional Info