Skip to content

set/unset ascii mode #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

set/unset ascii mode #1015

merged 2 commits into from
May 20, 2025

Conversation

lotem
Copy link
Member

@lotem lotem commented May 19, 2025

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Enhances ascii_composer:

  1. add new switch key options: set_ascii_mode, unset_ascii_mode;
  2. support alt, super key press.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

lotem added 2 commits May 20, 2025 00:40
config: `ascii_composer/switch_key/<keycode>: set_ascii_mode|unset_ascii_mode`
@lotem lotem requested a review from ksqsf May 19, 2025 17:00
Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lotem
Copy link
Member Author

lotem commented May 20, 2025

我給空格兩邊的修飾鍵設成中西文切換,左邊的切到西文,右邊的切到中文。

# default.custom.yaml
patch:
  ascii_composer/switch_key/+:
    Shift_L: noop
    Shift_R: noop
    Alt_L: set_ascii_mode
    Alt_R: unset_ascii_mode
    Super_L: set_ascii_mode
    Super_R: unset_ascii_mode

就這個感覺,爽爽爽爽。

PXL_20250514_090817409~2

@lotem lotem merged commit 2f24489 into rime:master May 20, 2025
10 checks passed
@lotem lotem deleted the set_ascii_mode branch May 23, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants