Skip to content

Run Vim in Web Worker and say goodbye to Emterpreter #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jun 12, 2019
Merged

Run Vim in Web Worker and say goodbye to Emterpreter #30

merged 20 commits into from
Jun 12, 2019

Conversation

rhysd
Copy link
Owner

@rhysd rhysd commented Jun 11, 2019 •
edited
Loading

Closes #10
Fixes #29

Please read README for more details.

👍 Benefits:

  • Pure Wasm (not Emterpreter byte code)!
  • Program is more stable
  • Total binary size is smaller since emterpretify.data has gone
  • Compilation is much faster
  • User interaction is not prevented as Vim is running in worker thread

👎 Downside:

  • JavaScript codebase is a bit more complicated because it is separated into main thread and worker thread
  • Browser support of SharedArrayBuffer is very limited in several major browsers due to Spectre. Only Chrome (and Chromium based browsers) enables it by default thanks to site-isolation

rhysd added 13 commits June 10, 2019 16:20
@rhysd
refactoring for preparing to separate JS logic into main thread and w…
800b54d 
…orker thread
@rhysd
separate JavaScript runtime into main thread and worker thread
8214d39 
but it still does not work because wait loop in gui_wasm.c does not
allow to fire onmessage event. Shared buffer must be used to send some
information from main thread to worker thread.
@rhysd
use shared array buffer to send events from main to worker
43b46c4
@rhysd
do not use 10ms polling since we have atomic wait with timeout
5ae7961
@rhysd
remove files no longer used and fix build script
b853535
@rhysd
use eslint-typescript instead of tslint
f0c8ca1
@rhysd
separate tsconfig.json for main thread and worker thread
deb6737
@rhysd
minify built JavaScript sources
3199910
@rhysd
rename worker.* to vim.*
fe381f5
@rhysd
update README for Web Worker updates
2160c4e
@rhysd
fix script to deploy
42fef28
@rhysd
update Development section
0e45eb2
@rhysd
refactor main thread JS code considering to expose it as package
fa162ce
@rhysd rhysd merged commit 24d20af into wasm Jun 12, 2019
@rhysd rhysd deleted the webworker branch June 12, 2019 09:48
This was referenced Jun 12, 2019
Closed
Closed
Closed
Closed
@zingus
Copy link

zingus commented Jan 12, 2020

Yeah... any workaround to that SharedArrayBuffer thing? Firefox isn't backing up on that.

@rhysd
Copy link
Owner Author

rhysd commented Jan 12, 2020

Please see #35. New Asyncify is an option. Though it is not acceptable to merge into master for now, it just works even on Firefox. You could try the branch.

@rhysd
Copy link
Owner Author

rhysd commented Jan 12, 2020

FYI: And Firefox is trying to enable SAB again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build sometimes fails with bad memory access
2 participants
@rhysd @zingus