Skip to content

Conversation

norwd
Copy link
Contributor

@norwd norwd commented Jan 15, 2023

This adds an action.yml file that downloads and installs the actionlint executable and runs it with options specified in the workflow file. Since the scripts/download-actionlint.bash file can get run in an action, the file also now uses the workflow commands to report errors/warnings etc... during the download.

@aschwenn
Copy link

would love to see this usable in github cis in this way

@rhysd
Copy link
Owner

rhysd commented Jan 18, 2023

This should be done in separate repository because tags of this repository are for actionlint command. Mixing tags for actionlint command releases and the action versions should be avoided. In addition, reusing the download script for executing actionlint is confusing and a bit hard to maintain.

Please make an issue and discuss there at first. Honestly I'm not seeing much difference between running the download script then executing the downloaded binary with run: and running the dedicated action with uses: though making a new action increases maintenance cost.

@norwd
Copy link
Contributor Author

norwd commented Jan 18, 2023

Please make an issue and discuss there first.

Will do 👍, please see #262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants