Skip to content

[BUG] timeout-minutes should allow expressions (but it demands floats) #384

@webknjaz

Description

@webknjaz

The same problem has just been fixed in the jsonschema based linter: python-jsonschema/check-jsonschema#354.

TL;DR the field should be either an expression or an integer. I don't think GHA actually allows floats in there like the error implies:

$ pre-commit run actionlint-docker --all-files -v 
Lint GitHub Actions workflow files.......................................Failed
- hook id: actionlint-docker
- duration: 1.03s
- exit code: 1

.github/workflows/reusable-build-wheel.yml:42:22: type of expression at "float number value" must be number but found type string [expression]
   |
42 |     timeout-minutes: ${{ inputs.qemu && 60 || 20 }}
   |                      ^~~

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions