Skip to content

feat-5 : added validateStatus #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2024
Merged

feat-5 : added validateStatus #6

merged 2 commits into from
Sep 4, 2024

Conversation

JiginJayaprakash
Copy link
Contributor

@rezmoss
Copy link
Owner

rezmoss commented Sep 3, 2024

Thanks, @JiginJayaprakash for your contribution! Did you run the test? I think you need to add a default value for validateStatus otherwise, all existing tests will fail

You can run all tests by go test -v

@JiginJayaprakash
Copy link
Contributor Author

thanks , @rezmoss . I have updated as per comments.

@rezmoss
Copy link
Owner

rezmoss commented Sep 4, 2024

@JiginJayaprakash Thx

@rezmoss rezmoss merged commit 6c6551a into rezmoss:main Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compare the response with Axios and implement any missing configurations
2 participants
@JiginJayaprakash @rezmoss