Fix project config based run with github-[pr-]check and github-pr-review reporters #1867
Conversation
With reviwedog project config, comment service can be called multiple times with each tool. reviewdog should report result with appropriate tool name for each tool correctly.
| @@ -78,9 +78,15 @@ func (ch *Check) GetResult() *CheckResult { | |||
| return ch.result | |||
| } | |||
|
|
|||
| func (ch *Check) SetTool(toolName string, level string) { | |||
There was a problem hiding this comment.
[golint-circleci] reported by reviewdog 🐶
exported method Check.SetTool should have comment or be unexported
| @@ -78,9 +78,15 @@ | |||
| return ch.result | |||
| } | |||
|
|
|||
| func (ch *Check) SetTool(toolName string, level string) { | |||
Check warning
Code scanning / golint
exported method Check.SetTool should have comment or be unexported
7617629 to
f932bf1
Compare
f932bf1 to
06df977
Compare
| @@ -123,6 +124,11 @@ func (g *PullRequest) Flush(ctx context.Context) error { | |||
| return g.postAsReviewComment(ctx) | |||
| } | |||
|
|
|||
| func (g *PullRequest) SetTool(toolName string, level string) { | |||
There was a problem hiding this comment.
[golint-circleci] reported by reviewdog 🐶
exported method PullRequest.SetTool should have comment or be unexported
714006e to
faca806
Compare
faca806 to
44acf18
Compare
| @@ -123,6 +124,11 @@ | |||
| return g.postAsReviewComment(ctx) | |||
| } | |||
|
|
|||
| func (g *PullRequest) SetTool(toolName string, level string) { | |||
Check warning
Code scanning / golint
exported method PullRequest.SetTool should have comment or be unexported
b9b435f to
cfedd04
Compare
| @@ -78,9 +78,15 @@ func (ch *Check) GetResult() *CheckResult { | |||
| return ch.result | |||
| } | |||
|
|
|||
| func (ch *Check) SetTool(toolName string, level string) { | |||
There was a problem hiding this comment.
[golint-by-project-conf] reported by reviewdog 🐶
exported method Check.SetTool should have comment or be unexported
| @@ -123,6 +124,11 @@ func (g *PullRequest) Flush(ctx context.Context) error { | |||
| return g.postAsReviewComment(ctx) | |||
| } | |||
|
|
|||
| func (g *PullRequest) SetTool(toolName string, level string) { | |||
There was a problem hiding this comment.
[golint-by-project-conf] reported by reviewdog 🐶
exported method PullRequest.SetTool should have comment or be unexported
| format: rdjson | ||
| test-project-conf: | ||
| cmd: | | ||
| echo '.reviewdog.yml:17: test project conf (errorformat)' |
There was a problem hiding this comment.
[test-project-conf] reported by reviewdog 🐶
test project conf (errorformat)
Co-authored-by: ICHINOSE Shogo <shogo82148@gmail.com>
Co-authored-by: ICHINOSE Shogo <shogo82148@gmail.com>
|
Oops, thank you for the suggestion! PTAL. |
|
@shogo82148 Can you take another look at this PR? Do you think it's ok to merge this? Thanks in advance! |
Tool name was incorrect for github-[pr-]check reporters and check API does not work correctly for project config based run (ref: Unexpected error exit code when using
-reporter=github-pr-checkwith-fail-on-error=true#1846)Deletion of outdated comment didn't work properly with github-pr-review reporter since tool name isn't correctly configured for project config based run
Updated Unreleased section in CHANGELOG or it's not notable changes.