Support posting comments outside diff context in github-pr-review reporter #1809

haya14busa · 2024-07-01T14:32:34Z

Updated Unreleased section in CHANGELOG or it's not notable changes.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

custom-rdjson

_testdata/custom.txt|3 col 5| code test 2 (rule w/ URL)
_testdata/custom.txt|3| source test
_testdata/custom.txt|16 col 1| diagnostic range != suggestion range

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

custom-rdjson

_testdata/custom.txt|3 col 5| code test 2 (rule w/ URL)
_testdata/custom.txt|3| source test
_testdata/custom.txt|16 col 1| diagnostic range != suggestion range

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

custom-rdjson

_testdata/custom.txt|3 col 5| code test 2 (rule w/ URL)
_testdata/custom.txt|3| source test
_testdata/custom.txt|16 col 1| diagnostic range != suggestion range

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

custom-rdjson

_testdata/custom.txt|3 col 5| code test 2 (rule w/ URL)
_testdata/custom.txt|3| source test
_testdata/custom.txt|16 col 1| diagnostic range != suggestion range

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

custom-rdjson

_testdata/custom.txt|3 col 5| code test 2 (rule w/ URL)
_testdata/custom.txt|3| source test
_testdata/custom.txt|16 col 1| diagnostic range != suggestion range
_testdata/custom.txt|| test file comment

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

custom-rdjson

_testdata/custom.txt|3 col 5| code test 2 (rule w/ URL)
_testdata/custom.txt|3| source test
_testdata/custom.txt|16 col 1| diagnostic range != suggestion range
_testdata/custom.txt|| test file comment

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

custom-rdjson

🚫 **[custom-rdjson]** <[E14](https://github.com/reviewdog/reviewdog#E14)> _{reported by [reviewdog](https://github.com/reviewdog/reviewdog) 🐶}
code test 2 (rule w/ URL) https://github.com/reviewdog/reviewdog/blob/f3bccd2509c13292ca5dee8757a25d3f6366b2fc/_testdata/custom.txt#L3

**[rdjsonl-source]** _{reported by [reviewdog](https://github.com/reviewdog/reviewdog) 🐶}
source test https://github.com/reviewdog/reviewdog/blob/f3bccd2509c13292ca5dee8757a25d3f6366b2fc/_testdata/custom.txt#L3

**[custom-rdjson]** _{reported by [reviewdog](https://github.com/reviewdog/reviewdog) 🐶}
diagnostic range != suggestion range https://github.com/reviewdog/reviewdog/blob/f3bccd2509c13292ca5dee8757a25d3f6366b2fc/_testdata/custom.txt#L16

**[custom-rdjson]** _{reported by [reviewdog](https://github.com/reviewdog/reviewdog) 🐶}
test file comment https://github.com/reviewdog/reviewdog/blob/f3bccd2509c13292ca5dee8757a25d3f6366b2fc/_testdata/custom.txt

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

custom-rdjson

🚫 [custom-rdjson] <E14> _{reported by reviewdog 🐶}
code test 2 (rule w/ URL)

reviewdog/_testdata/custom.txt

Line 3 in 3f99fc1

Line 3: Counter=1

[rdjsonl-source] _{reported by reviewdog 🐶}
source test

reviewdog/_testdata/custom.txt

Line 3 in 3f99fc1

Line 3: Counter=1

[custom-rdjson] _{reported by reviewdog 🐶}
diagnostic range != suggestion range

reviewdog/_testdata/custom.txt

Line 16 in 3f99fc1

{

[custom-rdjson] _{reported by reviewdog 🐶}
test file comment

https://github.com/reviewdog/reviewdog/blob/3f99fc16d967e68e201d68b1e5caaeec89fcae5a/_testdata/custom.txt

github-actions · 2024-07-02T10:10:56Z

_testdata/custom.txt

@@ -17,3 +17,5 @@
 }

 RelatedLoc


[custom-rdjson] _{reported by reviewdog 🐶}
test related location

Suggested change

RelatedLoc

test suggestion w/ related_locations

related loc 1

reviewdog/_testdata/custom.txt

Line 9 in 3f99fc1

---

related loc 2 (different file)

reviewdog/_testdata/suggestions.txt

Lines 6 to 8 in 3f99fc1

haya13busa (replace)

hayabusa (insert)

haya14busa (remove)

github-actions · 2024-07-02T10:11:05Z

_testdata/custom.txt

🚫 [custom-rdjson] _{reported by reviewdog 🐶}
code test 1 (rule only)

reviewdog/_testdata/custom.txt

Line 3 in 3f99fc1

Line 3: Counter=1

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

custom-rdjson

🚫 [custom-rdjson] <E14> _{reported by reviewdog 🐶}
code test 2 (rule w/ URL)

reviewdog/_testdata/custom.txt

Line 3 in 0f1bb55

Line 3: Counter=1

[rdjsonl-source] _{reported by reviewdog 🐶}
source test

reviewdog/_testdata/custom.txt

Line 3 in 0f1bb55

Line 3: Counter=1

[custom-rdjson] _{reported by reviewdog 🐶}
diagnostic range != suggestion range

reviewdog/_testdata/custom.txt

Line 16 in 0f1bb55

{

[custom-rdjson] _{reported by reviewdog 🐶}
test file comment

https://github.com/reviewdog/reviewdog/blob/0f1bb55446cd2edf22df3e57d65f15187ed00b61/_testdata/custom.txt

github-actions · 2024-07-02T10:15:57Z

_testdata/custom.txt

[custom-rdjson] _{reported by reviewdog 🐶}
range test 1 (line only)

reviewdog/_testdata/custom.txt

Lines 5 to 9 in 0f1bb55

--- Range

a = 11

b = 20

c = 30

---

github-actions · 2024-07-02T10:15:58Z

_testdata/custom.txt

[custom-rdjson] _{reported by reviewdog 🐶}
range test 2 (same line)

reviewdog/_testdata/custom.txt

Line 5 in 0f1bb55

--- Range

github-actions · 2024-07-02T10:15:59Z

_testdata/custom.txt

[custom-rdjson] _{reported by reviewdog 🐶}
range test 3 (with line-break)

reviewdog/_testdata/custom.txt

Lines 6 to 7 in 0f1bb55

a = 11

b = 20

github-actions · 2024-07-02T10:16:00Z

_testdata/custom.txt

[custom-rdjson] _{reported by reviewdog 🐶}
range test 4 (with line-break)

reviewdog/_testdata/custom.txt

Lines 6 to 9 in 0f1bb55

a = 11

b = 20

c = 30

---

github-actions · 2024-07-02T10:16:01Z

_testdata/custom.txt

[custom-rdjson] _{reported by reviewdog 🐶}
range test 5 (within line)

reviewdog/_testdata/custom.txt

Line 12 in 0f1bb55

haya14busa

github-actions · 2024-07-02T10:16:02Z

_testdata/custom.txt

📝 [custom-rdjson] _{reported by reviewdog 🐶}
severity test 1 (INFO)

reviewdog/_testdata/custom.txt

Line 3 in 0f1bb55

Line 3: Counter=1

github-actions · 2024-07-02T10:16:02Z

_testdata/custom.txt

⚠️ [custom-rdjson] _{reported by reviewdog 🐶}
severity test 2 (INFO)

reviewdog/_testdata/custom.txt

Line 3 in 0f1bb55

Line 3: Counter=1

github-actions · 2024-07-02T10:16:05Z

_testdata/custom.txt

🚫 [custom-rdjson] _{reported by reviewdog 🐶}
code test 1 (rule only)

reviewdog/_testdata/custom.txt

Line 3 in 0f1bb55

Line 3: Counter=1

github-actions · 2024-07-02T10:28:47Z

_testdata/custom.txt

🚫 [custom-rdjson] <E14> _{reported by reviewdog 🐶}
code test 2 (rule w/ URL)

reviewdog/_testdata/custom.txt

Line 3 in 98ca7c4

Line 3: Counter=1

github-actions · 2024-07-02T10:28:48Z

_testdata/custom.txt

[rdjsonl-source] _{reported by reviewdog 🐶}
source test

reviewdog/_testdata/custom.txt

Line 3 in 98ca7c4

Line 3: Counter=1

github-actions · 2024-07-02T10:28:49Z

_testdata/custom.txt

[custom-rdjson] _{reported by reviewdog 🐶}
diagnostic range != suggestion range

reviewdog/_testdata/custom.txt

Line 16 in 98ca7c4

{

github-actions · 2024-07-02T10:28:50Z

_testdata/custom.txt

[custom-rdjson] _{reported by reviewdog 🐶}
test file comment

Need google/go-github#3169

go.mod

github-actions bot reviewed Jul 1, 2024

View reviewed changes

reviewdog deleted a comment from github-actions bot Jul 1, 2024

github-actions bot reviewed Jul 1, 2024

View reviewed changes

reviewdog deleted a comment from github-actions bot Jul 1, 2024

github-actions bot reviewed Jul 1, 2024

View reviewed changes

github-actions bot reviewed Jul 2, 2024

View reviewed changes

haya14busa force-pushed the outside-context branch from f3bccd2 to 3f99fc1 Compare July 2, 2024 10:09

github-actions bot reviewed Jul 2, 2024

View reviewed changes

_testdata/custom.txt

Copy link

Contributor

github-actions bot Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[custom-rdjson] _{reported by reviewdog 🐶}
test file comment

haya14busa added 18 commits July 2, 2024 22:03

Update go-github version to v62

12a2b26

Use tip go-github

018519a

Need google/go-github#3169

Support posting comment outside diff for github-pr-review reporter

c305c69

use -filter-mode=nofilter for github-pr-review test

d939ff8

Add new line to test data text

6a43e6a

Use a pull request comment as a file comment appropriately

5b4d3e1

Fill in commit_id

3aaac10

fix pull request file comment

92151d2

fix empty repoBaseHTMLURL

3e1916a

Write snippet URL below body

c94b589

Add test file comment

8abd05d

Use -filter-mode=file for github-pr-annotations test

74524d7

Use code snippet for remaining findings report

215f597

empty commit

51684d2

fix githubCommentLine for FILE comment

f7a37bc

fix tests

2095c79

remove -filter-mode=file for github-pr-annotations test

b8e365a

update CHANGELOG

8a2b40e

haya14busa force-pushed the outside-context branch from 74c2cec to 8a2b40e Compare July 2, 2024 13:04

haya14busa marked this pull request as ready for review July 2, 2024 13:15

haya14busa requested a review from a team July 2, 2024 13:15

massongit reviewed Jul 2, 2024

View reviewed changes

go.mod Outdated Show resolved Hide resolved

fix go-github ver in go.mod

b20b457

haya14busa merged commit e647d87 into master Jul 6, 2024

haya14busa deleted the outside-context branch July 6, 2024 23:28

Uh oh!

Support posting comments outside diff context in github-pr-review reporter #1809

Support posting comments outside diff context in github-pr-review reporter #1809

Uh oh!

Conversation

haya14busa commented Jul 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

haya14busa Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

haya14busa commented Jul 1, 2024 •

edited

Loading