Skip to content

githubCommentLineRange: a same process is written only once #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2024
Merged

githubCommentLineRange: a same process is written only once #1805

merged 1 commit into from
Jun 30, 2024

Conversation

massongit
Copy link
Contributor

reviewdog/service/github/github.go

Lines 250 to 255 in 8aa60fd

startLine := loc.GetRange().GetStart().GetLine()
endLine := loc.GetRange().GetEnd().GetLine()
if endLine == 0 {
endLine = startLine
}
return int(startLine), int(endLine)

The above code is common regardless of the branch of the if statement.
Therefore, I refactor it so that it is written only once.

  • Updated Unreleased section in CHANGELOG or it's not notable changes.
    • It's not notable changes.

@haya14busa haya14busa merged commit f31b773 into reviewdog:master Jun 30, 2024
@massongit massongit deleted the refactor_github_comment_line_range branch June 30, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haya14busa haya14busa haya14busa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@massongit @haya14busa