Introduce comment metadata and fingerprint for identifying existing posted comments #1792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
review-dog
reviewed
Jun 17, 2024
| @@ -9,13 +9,13 @@ import ( | |||
| "github.com/reviewdog/reviewdog/proto/rdf" | |||
| ) | |||
|
|
|||
| // `path` to `position`(Lnum for new file) to comment `body`s | |||
| // `path` to `position`(Lnum for new file) to comment `body` or `finterprint` | |||
There was a problem hiding this comment.
[golint-circleci] reported by reviewdog 🐶
comment on exported type PostedComments should be of the form "PostedComments ..." (with optional leading article)
| @@ -9,13 +9,13 @@ | |||
| "github.com/reviewdog/reviewdog/proto/rdf" | |||
| ) | |||
|
|
|||
| // `path` to `position`(Lnum for new file) to comment `body`s | |||
| // `path` to `position`(Lnum for new file) to comment `body` or `finterprint` | |||
There was a problem hiding this comment.
[golint-pr-review] reported by reviewdog 🐶
comment on exported type PostedComments should be of the form "PostedComments ..." (with optional leading article)
review-dog
reviewed
Jun 18, 2024
dba3dfd to
7ddaa4e
Compare
Now reviwedog include metadata as HTML comment for github-pr-review reporter. We can now use calculated fingerprint to identify existing posted comments. It resolves the problem w.r.t. related location feature. Since reviewdog include the latest SHA in body of comment for relate location feature, comparing comment body cannot be used for identifying existing comments and it leads to post duplicate comments. We can avoid this problem with fingerprint check.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
b33170b to
b501e9b
Compare
shogo82148
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce metadata comment and fingerprint to github-pr-review reporter
Now reviwedog include metadata as HTML comment for github-pr-review
reporter.
We can now use calculated fingerprint to identify existing posted comments.
It resolves the problem w.r.t. related location feature.
Since reviewdog include the latest SHA in body of comment for relate
location feature, comparing comment body cannot be used for identifying
existing comments and it leads to post duplicate comments.
We can avoid this problem with fingerprint check.