Refactor doghouse / github-[pr-]check related code #1798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
review-dog
reviewed
Jun 22, 2024
review-dog
reviewed
Jun 22, 2024
review-dog
reviewed
Jun 29, 2024
1. Implement GitHub Check API flow as CommentService / DiffService
2. Use the above {Comment,Diff}Service if reviewdog won't talk to
the doghouse server
3. Implement github-pr-annotations reporter as {Comment,Diff}Service
4. It means doghouse related code should be used only when reviewdog
needs to talk to the doghouse server
454aea7 to
6e70db3
Compare
review-dog
reviewed
Jun 29, 2024
f6ee89c to
b8b64ff
Compare
Comment on lines
5
to
9
| --- Range | ||
| a = 10 | ||
| a = 11 | ||
| b = 20 | ||
| c = 30 | ||
| --- |
There was a problem hiding this comment.
[custom-rdjson] reported by reviewdog 🐶
range test 1 (line only)
Comment on lines
+6
to
7
| a = 11 | ||
| b = 20 |
There was a problem hiding this comment.
[custom-rdjson] reported by reviewdog 🐶
range test 3 (with line-break)
Comment on lines
+6
to
9
| a = 11 | ||
| b = 20 | ||
| c = 30 | ||
| --- |
There was a problem hiding this comment.
[custom-rdjson] reported by reviewdog 🐶
range test 4 (with line-break)
Comment on lines
5
to
9
| --- Range | ||
| a = 10 | ||
| a = 11 | ||
| b = 20 | ||
| c = 30 | ||
| --- |
There was a problem hiding this comment.
[custom-rdjson] reported by reviewdog 🐶
range test 1 (line only)
Comment on lines
+6
to
7
| a = 11 | ||
| b = 20 |
There was a problem hiding this comment.
[custom-rdjson] reported by reviewdog 🐶
range test 3 (with line-break)
Comment on lines
+6
to
9
| a = 11 | ||
| b = 20 | ||
| c = 30 | ||
| --- |
There was a problem hiding this comment.
[custom-rdjson] reported by reviewdog 🐶
range test 4 (with line-break)
Co-authored-by: ICHINOSE Shogo <shogo82148@gmail.com>
|
Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the doghouse server (reviewdog GitHub App)
needs to talk to the doghouse server