Skip to content

extend golangci-lint timeout #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2024
Merged

extend golangci-lint timeout #1650

merged 1 commit into from
Jan 24, 2024

Conversation

shogo82148
Copy link
Contributor

@shogo82148 shogo82148 commented Jan 23, 2024 •
edited
Loading

golangci-lint workflow sometimes fails with timeout error: https://github.com/reviewdog/reviewdog/actions/runs/7627118782/job/20775054992?pr=1649

   level=error msg="Timeout exceeded: try increasing it by passing --timeout option"
Error: Error: golangci-lint exited with status code: 4

This pull request will fix it.

  • Updated Unreleased section in CHANGELOG or it's not notable changes.

@shogo82148 shogo82148 requested a review from shmokmt January 23, 2024 14:39
shmokmt
shmokmt approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@shmokmt shmokmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@shogo82148 shogo82148 enabled auto-merge January 24, 2024 02:48
@shmokmt
Copy link
Member

shmokmt commented Jan 24, 2024 •
edited
Loading

I don't have write permission on this repository, so it looks like you won't be able to merge this PR even if I approved 💭

haya14busa
haya14busa approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@haya14busa haya14busa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take a look other PRs too within a few days. Thank you for your continuous contribution.

@shogo82148 shogo82148 merged commit 6a6d80e into master Jan 24, 2024
@shogo82148 shogo82148 deleted the extend-golangci-lint-timeout branch January 24, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haya14busa haya14busa haya14busa approved these changes

+1 more reviewer

@shmokmt shmokmt shmokmt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shogo82148 @shmokmt @haya14busa