Skip to content

Conversation

varunsh-coder
Copy link
Contributor

This PR adds specific permissions to the existing workflows under .github/workflows.

Background

GitHub provides a feature to set permissions for the GITHUB_TOKEN. I have implemented a GitHub App to automatically calculate the right permissions for a given workflow.

I am trying the App out on public repositories, by forking them, installing the App on the fork, and manually creating PRs with the fixed workflows.

I have manually reviewed the changes, and they do look good to me. If something looks off, please let me know. Please try it out on other repos and share your feedback. Thanks!

  • Updated Unreleased section in CHANGELOG or it's not notable changes.

Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shogo82148 shogo82148 merged commit 89aa61b into reviewdog:master Sep 12, 2021
@review-dog
Copy link
Member

Hi, @varunsh-coder! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintainance of reviewdog.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants