Skip to content

Improve gitlab suggestion #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 8, 2021
Merged

Improve gitlab suggestion #1022

merged 3 commits into from
Aug 8, 2021

Conversation

shogo82148
Copy link
Contributor

I implemented this #1017 (comment)

Thank you for your review.

Can you create a helper function to get # of backticks for suggestions considering there are duplicated code?

I created it in the commentutil package.
Because we might need same fix with Gitlab suggestions in merge request comments(#1012).
I think using quadruple backticks(````) is very very rarely, but linters can.
I'm going to do it in another pull request.

  • Updated Unreleased section in CHANGELOG or it's not notable changes.

haya14busa
haya14busa approved these changes Aug 8, 2021
View reviewed changes
Copy link
Member

@haya14busa haya14busa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@shogo82148 shogo82148 merged commit c8a137c into master Aug 8, 2021
@shogo82148 shogo82148 deleted the improve-gitlab-suggestion branch August 8, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haya14busa haya14busa haya14busa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shogo82148 @haya14busa