refactor: create parser package #690
Conversation
haya14busa
commented
Jul 25, 2020
- Updated Unreleased section in CHANGELOG or it's not notable changes.
| return &CheckStyleParser{} | ||
| } | ||
|
|
||
| func (p *CheckStyleParser) Parse(r io.Reader) ([]*rdf.Diagnostic, error) { |
There was a problem hiding this comment.
[golint-circleci] reported by reviewdog 🐶
exported method CheckStyleParser.Parse should have comment or be unexported
| return NewErrorformatParser(efm), nil | ||
| } | ||
|
|
||
| func (p *ErrorformatParser) Parse(r io.Reader) ([]*rdf.Diagnostic, error) { |
There was a problem hiding this comment.
[golint-circleci] reported by reviewdog 🐶
exported method ErrorformatParser.Parse should have comment or be unexported
parser/parser.go
Outdated
|
|
||
| // ParserOpt represents option to create Parser. Either FormatName or | ||
| // Errorformat should be specified. | ||
| type ParserOpt struct { |
There was a problem hiding this comment.
[golint-circleci] reported by reviewdog 🐶
type name will be used as parser.ParserOpt by other packages, and that stutters; consider calling this Opt
| // RDJSONLParser is parser for rdjsonl format. | ||
| type RDJSONLParser struct{} | ||
|
|
||
| func NewRDJSONLParser() *RDJSONLParser { |
There was a problem hiding this comment.
[golint-circleci] reported by reviewdog 🐶
exported function NewRDJSONLParser should have comment or be unexported
| return &RDJSONLParser{} | ||
| } | ||
|
|
||
| func (p *RDJSONLParser) Parse(r io.Reader) ([]*rdf.Diagnostic, error) { |
There was a problem hiding this comment.
[golint-circleci] reported by reviewdog 🐶
exported method RDJSONLParser.Parse should have comment or be unexported
| return &CheckStyleParser{} | ||
| } | ||
|
|
||
| func (p *CheckStyleParser) Parse(r io.Reader) ([]*rdf.Diagnostic, error) { |
There was a problem hiding this comment.
[golint-pr-review] reported by reviewdog 🐶
exported method CheckStyleParser.Parse should have comment or be unexported
| return NewErrorformatParser(efm), nil | ||
| } | ||
|
|
||
| func (p *ErrorformatParser) Parse(r io.Reader) ([]*rdf.Diagnostic, error) { |
There was a problem hiding this comment.
[golint-pr-review] reported by reviewdog 🐶
exported method ErrorformatParser.Parse should have comment or be unexported
parser/parser.go
Outdated
|
|
||
| // ParserOpt represents option to create Parser. Either FormatName or | ||
| // Errorformat should be specified. | ||
| type ParserOpt struct { |
There was a problem hiding this comment.
[golint-pr-review] reported by reviewdog 🐶
type name will be used as parser.ParserOpt by other packages, and that stutters; consider calling this Opt
| // RDJSONLParser is parser for rdjsonl format. | ||
| type RDJSONLParser struct{} | ||
|
|
||
| func NewRDJSONLParser() *RDJSONLParser { |
There was a problem hiding this comment.
[golint-pr-review] reported by reviewdog 🐶
exported function NewRDJSONLParser should have comment or be unexported
| return &RDJSONLParser{} | ||
| } | ||
|
|
||
| func (p *RDJSONLParser) Parse(r io.Reader) ([]*rdf.Diagnostic, error) { |
There was a problem hiding this comment.
[golint-pr-review] reported by reviewdog 🐶
exported method RDJSONLParser.Parse should have comment or be unexported