Use Diagnostic.original_output internally and remove CheckResult type #689
Conversation
| @@ -71,26 +72,24 @@ func NewErrorformatParserString(efms []string) (*ErrorformatParser, error) { | |||
| return NewErrorformatParser(efm), nil | |||
| } | |||
|
|
|||
| func (p *ErrorformatParser) Parse(r io.Reader) ([]*CheckResult, error) { | |||
| func (p *ErrorformatParser) Parse(r io.Reader) ([]*rdf.Diagnostic, error) { | |||
There was a problem hiding this comment.
[golint-circleci] reported by reviewdog 🐶
exported method ErrorformatParser.Parse should have comment or be unexported
| @@ -107,31 +106,27 @@ func NewCheckStyleParser() Parser { | |||
| return &CheckStyleParser{} | |||
| } | |||
|
|
|||
| func (p *CheckStyleParser) Parse(r io.Reader) ([]*CheckResult, error) { | |||
| func (p *CheckStyleParser) Parse(r io.Reader) ([]*rdf.Diagnostic, error) { | |||
There was a problem hiding this comment.
[golint-circleci] reported by reviewdog 🐶
exported method CheckStyleParser.Parse should have comment or be unexported
| @@ -172,15 +167,19 @@ func NewRDJSONLParser() *RDJSONLParser { | |||
| return &RDJSONLParser{} | |||
| } | |||
|
|
|||
| func (p *RDJSONLParser) Parse(r io.Reader) ([]*CheckResult, error) { | |||
| var results []*CheckResult | |||
| func (p *RDJSONLParser) Parse(r io.Reader) ([]*rdf.Diagnostic, error) { | |||
There was a problem hiding this comment.
[golint-circleci] reported by reviewdog 🐶
exported method RDJSONLParser.Parse should have comment or be unexported
| @@ -71,26 +72,24 @@ | |||
| return NewErrorformatParser(efm), nil | |||
| } | |||
|
|
|||
| func (p *ErrorformatParser) Parse(r io.Reader) ([]*CheckResult, error) { | |||
| func (p *ErrorformatParser) Parse(r io.Reader) ([]*rdf.Diagnostic, error) { | |||
There was a problem hiding this comment.
[golint-pr-review] reported by reviewdog 🐶
exported method ErrorformatParser.Parse should have comment or be unexported
| @@ -107,31 +106,27 @@ | |||
| return &CheckStyleParser{} | |||
| } | |||
|
|
|||
| func (p *CheckStyleParser) Parse(r io.Reader) ([]*CheckResult, error) { | |||
| func (p *CheckStyleParser) Parse(r io.Reader) ([]*rdf.Diagnostic, error) { | |||
There was a problem hiding this comment.
[golint-pr-review] reported by reviewdog 🐶
exported method CheckStyleParser.Parse should have comment or be unexported
| @@ -172,15 +167,19 @@ | |||
| return &RDJSONLParser{} | |||
| } | |||
|
|
|||
| func (p *RDJSONLParser) Parse(r io.Reader) ([]*CheckResult, error) { | |||
| var results []*CheckResult | |||
| func (p *RDJSONLParser) Parse(r io.Reader) ([]*rdf.Diagnostic, error) { | |||
There was a problem hiding this comment.
[golint-pr-review] reported by reviewdog 🐶
exported method RDJSONLParser.Parse should have comment or be unexported
follow up of #688