Skip to content

Conversation

haya14busa
Copy link
Member

@haya14busa haya14busa commented Jul 22, 2020

Support annotation level per result and range annotation.

  • Updated Unreleased section in CHANGELOG or it's not notable changes.

@haya14busa haya14busa changed the title github-check: Support Reviewdog Diagnostic Format and annotation level conversion github-check: Support Reviewdog Diagnostic Format Jul 22, 2020
@haya14busa haya14busa force-pushed the rdformat-github-check branch from 28b9ed6 to 84a116f Compare July 22, 2020 17:35

--- Range
a = 1
b = 2
c = 3
---

1234567890
haya14busa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[custom-rdjsonl] reported by reviewdog 🐶
range test 5 (within line)

@@ -1,9 +1,13 @@
Custom text for testing

line 5
Line 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[custom-rdjsonl] reported by reviewdog 🐶
severity test 1

@@ -1,9 +1,13 @@
Custom text for testing

line 5
Line 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[custom-rdjsonl] reported by reviewdog 🐶
severity test 2

Comment on lines 5 to 9
--- Range
a = 1
b = 2
c = 3
a = 10
b = 20
c = 30
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[custom-rdjsonl] reported by reviewdog 🐶
range test 1 (line only)

a = 1
b = 2
c = 3
a = 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[custom-rdjsonl] reported by reviewdog 🐶
range test 3 (with line-break)

Comment on lines +6 to +8
a = 10
b = 20
c = 30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[custom-rdjsonl] reported by reviewdog 🐶
range test 4 (with line-break)

@haya14busa haya14busa merged commit e696428 into master Jul 24, 2020
@haya14busa haya14busa deleted the rdformat-github-check branch July 24, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant