Fix detection logic to determin Pull Requests from forked repo #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
review-dog
reviewed
Jun 29, 2020
| @@ -24,15 +24,22 @@ | |||
| } `json:"head_commit"` | |||
| } | |||
|
|
|||
| type GitHubRepo struct { | |||
There was a problem hiding this comment.
[golint-pr-review] reported by reviewdog 🐶
exported type GitHubRepo should have comment or be unexported
Head and base repos can be the same *forked* repo, so refering to head repo's "fork" field was not enough. Fix #603
|
tested: review-dog#2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Head and base repos can be the same forked repo, so refering to head
repo's "fork" field was not enough.
Fix #603