Support subdir for [github-check,github-pr-check] and fix subdir handling for other reporter as well #468
Conversation
|
Thanks for this PR @haya14busa |
|
Is there any update on this PR status? Can it be merged? |
|
Any update on merging this? I would love to be able to use this on my team's project |
|
Our team might need to look into a different solution if this doesn't get reviewed soon, please if you get time can you merge this @mgrachev |
| "github.com/reviewdog/reviewdog" | ||
| ) | ||
|
|
||
| // `path` to `position`(Lnum for new file) to comment `body`s |
There was a problem hiding this comment.
[golint-circleci] reported by reviewdog 🐶
comment on exported type PostedComments should be of the form "PostedComments ..." (with optional leading article)
| "github.com/reviewdog/reviewdog" | ||
| ) | ||
|
|
||
| // `path` to `position`(Lnum for new file) to comment `body`s |
There was a problem hiding this comment.
[golint-pr-review] reported by reviewdog 🐶
comment on exported type PostedComments should be of the form "PostedComments ..." (with optional leading article)
| @@ -1,3 +1,3 @@ | |||
| package testdata | |||
|
|
|||
| var X = 1 | |||
| var X = 2 | |||
There was a problem hiding this comment.
[golint-pr-review-subdir] reported by reviewdog 🐶
exported var X should have comment or be unexported
|
This PR was pending because I noticed that it actually didn't work well for other reporters like |
difffilter can only support diff with path from repository root
In doghouse flow, given annotation path is already relative path to the root repository, but if it's running in GitHub actions, the relative path was prepended again because it can run git command. Disable relative path to project root handling if cwd is empty. follow-up of #468
In doghouse flow, given annotation path is already relative path to the root repository, but if it's running in GitHub actions, the relative path was prepended again because it can run git command. Disable relative path to project root handling if cwd is empty. follow-up of #468
Uh oh!
There was an error while loading. Please reload this page.