-
-
Notifications
You must be signed in to change notification settings - Fork 457
Closed
Description
if !c.Result.InDiffContext {
// If the result is outside of diff context, fallback to GitHub Review
// Comment API.
comment := buildPullRequestComment(c, body, g.sha)
plainComments = append(plainComments, comment)
continue
}
This block of code does not seem to function correctly.
The error:
2024/01/22 15:24:23 reviewdog: failed to post a pull request comment: POST https://github....: 422 Invalid request.
No subschema in "oneOf" matched.
"position" wasn't supplied.
"in_reply_to" wasn't supplied.
"subject_type" is not a permitted key.
"line" wasn't supplied. []
The github api attempting to be used is v3
review dog was not being run as a github action.
simply giving a line of 0 (or the real line number if one exists) might fix this, but i didn't keep going past figuring out where the error was coming from and why. I simply switched to diff_context only.
Metadata
Metadata
Assignees
Labels
No labels