-
-
Notifications
You must be signed in to change notification settings - Fork 3
Refactor from docker to composite action #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently the staticcheck repository has a weird naming pattern for releases. Instead of the version they name the release after the day on which it was created. That makes it quite difficult to allow the user to choose the staticcheck version. However before the refactoring we also always used the latest one, so this is not really a downgrade. |
That is not quite correct. The versioning scheme is |
Ah thnx for the insights 👍 . |
@kstiehl Thank you for the great work! LGTM 👍 @dominikh |
🚀 [bumpr] Bumped! New version:v1.5.0 Changes:v1.4.3...v1.5.0 |
I filed #17 for the follow-up :) |
Well, not precisely. There is a separate set of tags that exist explicitly to make Go modules happy. These are In general, it's recommended to always read the release notes of Staticcheck before upgrading to a new version, which precludes fully automatic updates. |
Thanks for the clarification! I understand it's not semantically the same as the semver, but as long as the format is
Yes! I meant I'd like to automate the update flow, especially for creating a Pull Request (like dependabot/renovate) so that we can notice new releases of staticcheck and make it easy to bump the version. We can check the release note before merging it. |
The action have been migrated from a Docker action to a composite action. #16 So hadolint a Dockerfile linter is no longer needed.
As discussed in #14 here is the refactoring of the action so that it is a composite action now.
This PR should fix #9