fix: text parameter from file #70
Conversation
|
@haya14busa Any chance you can take a look at this? |
|
Hi, @2color! We merged your PR to reviewdog! 🐶 We just invited you to join the @reviewdog organization on GitHub. Thanks again! |
|
🚀 [bumpr] Bumped! New version:v1.20.1 Changes:v1.20.0...v1.20.1 |
|
Hey, we recently started to get errors that stops the pipeline on empty index.md files (for structural reasons). This seems related |
|
@Isengo1989 can you please try #71 Can you check if that file it's checking is empty? It's strange that Curl is not sending an empty You can try it by updating the branch name in your workflow to |
|
Hey @2color - yes this seems to fix it. Here is a PR using that branch https://github.com/shopware/docs/actions/runs/12903720329/job/35979487619?pr=1664 and as a reference a branch with default v1 failing https://github.com/shopware/docs/actions/runs/12903760139/job/35979605655?pr=1665 |
|
#71 has been merged. So this should be fine! Thanks for reporting. |
Great 👍 Thanks for the quick reply and fix 🙂 |
Background
inlined
cating of a file in the curl command can cause problems with shell escape characters. Especially if the text/markdown file at hand is large and contains a lot of special characters like [this example from the IPFS Docs, where I discovered this bug]https://github.com/ipfs/ipfs-docs/blob/84a4445592a6763796f92aa972d0a529e8d193c3/docs/reference/kubo/cli.md).This causes the problems mentioned in #32
What's in this PR
This changes uses the
fieldname@filenamepattern in Curl to have CURL load the contents of the file.This fixes #32 and has been confirmed to work in https://github.com/ipfs/ipfs-docs/actions/runs/12884342273/job/35920448036#step:4:448