Timeago Template Func #1207
Merged
Timeago Template Func #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notzippy
requested changes
Jul 22, 2017
template_functions.go
Outdated
| @@ -145,6 +146,35 @@ var ( | |||
| }, | |||
| "slug": Slug, | |||
| "even": func(a int) bool { return (a % 2) == 0 }, | |||
|
|
|||
| // Using https://github.com/xeonx/timeago | |||
| "timeago": func(viewArgs map[string]interface{}, datetime time.Time) string { | |||
There was a problem hiding this comment.
If possible can you modify this so it behaves similar to the i18template function.
Basically allow for variable number of arguments
- If one argument format the time as the default lang in the app.conf
- if two arguments, and second one is string assume that is the region
- if two arguments, and second is map assume that is the viewArgs and extract the CurrentLocaleViewArg from the map
template_functions.go
Outdated
| return timeago.English.Format(datetime) | ||
| } | ||
| // internalization by current locale | ||
| var customLanguage = timeago.Config{ |
There was a problem hiding this comment.
Store the customLanguage outside the function in a map keyed by the localeStr, so that a new timeago.Config object doesnt get created every time a this template function is called
|
@notzippy Please check the changes, I'll wait for your comments. |
notzippy
requested changes
Jul 23, 2017
template_functions.go
Outdated
| switch len(args) { | ||
| case 0: | ||
| ERROR.Printf("No arguements passed to template call") | ||
| case 1: |
There was a problem hiding this comment.
Probably shoud say no arguements passed to TimeAgo call
notzippy
approved these changes
Jul 23, 2017
brendensoares
approved these changes
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new template function (Go) called "timeago" using https://github.com/xeonx/timeago
Documentation added to the website.
If the PR is accepted, consider the documentation revel/revel.github.io#133.