JSON Parameter binding #1173
Merged
JSON Parameter binding #1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2bf0f4 to
5cbae9e
Compare
…on to not store validation state via a cookie, since with a json request/response no redirect is required and therefor no persistent data is required. Also renamed local variable error to err so no package conflict error will occur
1 task
brendensoares
approved these changes
May 31, 2017
params.go
Outdated
| @@ -31,6 +32,7 @@ type Params struct { | |||
|
|
|||
| Files map[string][]*multipart.FileHeader // Files uploaded in a multipart form | |||
| tmpFiles []*os.File // Temp files used during the request. | |||
| Json []byte // JSON data from request body | |||
params.go
Outdated
| ERROR.Println("Failed to ready request body bytes",err) | ||
| } | ||
| } else { | ||
| INFO.Println("Json post received with empty body") |
| } | ||
| hasCookie := (err != http.ErrNoCookie) | ||
| // If json request, we shall assume json response is intended, | ||
| // as such no validation cookies should be tied response |
params.go
Outdated
| case "application/json": | ||
| fallthrough | ||
| case "text/json": | ||
| if req.Body!=nil { |
| keep: false, | ||
| } | ||
| hasCookie := (err != http.ErrNoCookie) | ||
| // If json request, we shall assume json response is intended, |
Updated params so that Params.Bind() does not blindly bind json data Added Params.BindJSON() to provide JSON bind functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic JSON binding to struct in parameters, also changed validation to not store validation state via a cookie, since with a json request/response no redirect is required and therefor no persistent data is required.
Also renamed local variable error to err so no package conflict error will occur