Server Engine 2 #1171
Merged
Server Engine 2 #1171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # binder.go # binder_test.go # http.go # params.go # results.go # revel.go # template.go # validation.go
brendensoares
requested changes
Jun 21, 2017
controller.go
Outdated
| @@ -24,7 +24,7 @@ type Controller struct { | |||
| Type *ControllerType // A description of the controller type. | |||
| MethodName string // The method name, e.g. "Index" | |||
| MethodType *MethodType // A description of the invoked action type. | |||
| AppController interface{} // The controller that was instantiated. | |||
| AppController interface{} // The controller that was instantiated. extends from revel.Controller | |||
compress.go
Outdated
| return | ||
| } | ||
|
|
||
| // This class will not send content out until the Released is called, from that point on it will act normally |
There was a problem hiding this comment.
wording. This class to BufferedServerHeader per godoc conventions and also, it's a struct not a class
http.go
Outdated
| "sort" | ||
| "strconv" | ||
| "strings" | ||
|
|
||
| "golang.org/x/net/websocket" | ||
| "mime/multipart" | ||
| "path/filepath" | ||
| ) | ||
|
|
||
| // Request Revel's HTTP request object structure |
http.go
Outdated
| "path/filepath" | ||
| ) | ||
|
|
||
| // Request Revel's HTTP request object structure | ||
| type Request struct { | ||
| *http.Request | ||
| In ServerRequest | ||
| Header *RevelHeader |
http.go
Outdated
| ContentType string | ||
| Format string // "html", "xml", "json", or "txt" | ||
| AcceptLanguages AcceptLanguages | ||
| Locale string | ||
| Websocket *websocket.Conn | ||
| Websocket ServerWebSocket |
| ENGINE_RESPONSE | ||
| ) | ||
| const ( | ||
| /* HTTP Engine Type Values Starts at 1000 */ |
There was a problem hiding this comment.
That gives room for the Minimum Engine constants listed before this block
| @@ -0,0 +1,416 @@ | |||
| package revel | |||
There was a problem hiding this comment.
there is already a file called template_agapter_go.go so this is consistent with that
simplestack.go
Outdated
|
|
||
| ss.Current = current | ||
|
|
||
| //nc := *current |
testing/testsuite_test.go
Outdated
| Addr: ":9001", | ||
| } | ||
| if revel.CurrentEngine == nil { | ||
| revel.InitServerEngine(9001, revel.GO_NATIVE_SERVER_ENGINE) |
There was a problem hiding this comment.
That is what it was set to before
watcher.go
Outdated
| @@ -56,6 +56,7 @@ func (w *Watcher) Listen(listener Listener, roots ...string) { | |||
| // Otherwise multiple change events only come out one at a time, across | |||
| // multiple page views. (There appears no way to "pump" the events out of | |||
| // the watcher) | |||
| // This causes a notification when you do a check in GOLang, since you are modifying a buffer in use | |||
|
Note the build will fail because revel/cmd needs the changes merged as well |
compress.go
Outdated
| compressionType: compressType, | ||
| headersWritten: false, | ||
| closeNotify: make(chan bool, 1), | ||
| closed: false} |
There was a problem hiding this comment.
add , and put } on new line?
# Conflicts: # controller.go # fakeapp_test.go # revel.go # router.go # server.go
…nstead of by key, this allows for a headers case insensitive fetch
ae7f23b to
e64e747
Compare
brendensoares
approved these changes
Jul 24, 2017
|
@notzippy How from |
|
In the Go server engine the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimum changes for server engine to work