Sort controllers so that builds are reproducible. #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ordering of controllers in routes.go and main.go is unstable in successive runs of revel build. This change will assure that the ordering is stable.
notzippy
reviewed
Dec 8, 2017
harness/build.go
Outdated
| @@ -42,6 +42,10 @@ func Build(buildFlags ...string) (app *App, compileError *revel.Error) { | |||
| sourceInfo.InitImportPaths = append(sourceInfo.InitImportPaths, strings.Split(dbImportPath,",")...) | |||
| } | |||
|
|
|||
| // Sort controllers so that file generation is reproducible | |||
| controllers := sourceInfo.ControllerSpecs() | |||
| sort.SliceStable(controllers, func(i, j int) bool { return controllers[i].String() < controllers[j].String() }) | |||
There was a problem hiding this comment.
Nice idea, can you make this compatible with go 1.6 (sort.SliceStable isnt available until 1.8) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ordering of controllers in routes.go and main.go is unstable in
successive runs of revel build. This change will assure that the
ordering is stable.