Skip to content

Add more terms #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2021
Merged

Add more terms #116

merged 3 commits into from
Nov 11, 2021

Conversation

stevemk14ebr
Copy link
Contributor

@stevemk14ebr stevemk14ebr commented Nov 10, 2021

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Added english terms

  • slave
  • slaves
  • blackhat
  • whitehat
  • man hours

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Nov 10, 2021
@github-actions

This comment has been minimized.

@wooorm
Copy link
Member

wooorm commented Nov 10, 2021

Can you run npm test locally? That should generate some code!

@stevemk14ebr
Copy link
Contributor Author

Ok done. I added a console log too in the generator since the exception didn't actually mention the phrase name that is a duplicate in the error. This showed me that my addition of man hours was a duplicate, so that was removed too.

@wooorm
Copy link
Member

wooorm commented Nov 10, 2021

I don’t get the console.log? It’s the same phrases[index] as shown in the error? 🤔

@codecov-commenter

This comment has been minimized.

@stevemk14ebr
Copy link
Contributor Author

I don’t get the console.log? It’s the same phrases[index] as shown in the error? 🤔

I am dumb and didn't see the next line:

       throw new Error('Refrain from multiple entries:\n  ' + phrases[offset])
            ^

Error: Refrain from multiple entries:
  man hours   <------ misssed this

Will remove

@wooorm wooorm merged commit aa29dd3 into retextjs:main Nov 11, 2021
@github-actions

This comment has been minimized.

@wooorm wooorm added 💪 phase/solved Post is done 🗄 area/interface This affects the public interface 🦋 type/enhancement This is great to have 🧒 semver/minor This is backwards-compatible change labels Nov 11, 2021
@github-actions github-actions bot removed the 👋 phase/new Post is being triaged automatically label Nov 11, 2021
@wooorm
Copy link
Member

wooorm commented Nov 11, 2021

released, thanks!

nerditron pushed a commit to nerditron/retext-anti-woke that referenced this pull request Mar 15, 2025
Reviewed-by: Titus Wormer <tituswormer@gmail.com>

Closes retextjsGH-116.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

3 participants