Upgrade to replicated lib beta.13 #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emosbaugh
requested changes
Apr 19, 2024
create-object-store/action.yml
Outdated
Comment on lines
12
to
15
| bucket-name: | ||
| description: "Name of the bucket to create" | ||
| required: true | ||
| default: "" |
There was a problem hiding this comment.
We should be consistent with the cli for all inputs
Suggested change
| bucket-name: | |
| description: "Name of the bucket to create" | |
| required: true | |
| default: "" | |
| bucket-prefix: | |
| description: "A prefix for the bucket name to be created" | |
| required: true | |
| default: "" |
There was a problem hiding this comment.
The cli uses bucket as flag
| description: "Instance type to provision" | ||
| required: false | ||
| disk: | ||
| description: "Disk size in GiB" |
There was a problem hiding this comment.
The cli sets the default to be 200 GiB. Do we need to do the same or will the api handle that?
There was a problem hiding this comment.
Yes, if empty, the api should handle it.
emosbaugh
previously approved these changes
Apr 19, 2024
emosbaugh
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
0.0.1-beta.13For review:
Anything under
distis generated and can be ignored.