Skip to content

fix: handle error messages better for cog push with pipelines #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

fix: handle error messages better for cog push with pipelines #2435

merged 1 commit into from
Jul 1, 2025

Conversation

markphelps
Copy link
Contributor

  • return error message directly for cog push to new versions endpoint instead of doing string comparison
  • minor cleanup for if/err checks
  • use time.Since instead of time.Now.Sub

@markphelps
fix: handle error messages better for cog push with pipelines
5f7ceec 
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
@markphelps markphelps requested review from aron and 8W9aG and removed request for aron July 1, 2025 18:23
@markphelps markphelps merged commit dbaf981 into main Jul 1, 2025
26 checks passed
@markphelps markphelps deleted the fix/DP-189/cog-procedure-err-msg-handling branch July 1, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8W9aG 8W9aG 8W9aG approved these changes

@aron aron Awaiting requested review from aron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markphelps @8W9aG