Fix flakey integration tests #2420
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few integration tests that fail randomly due to a race, eg:
The issue is that several integration tests alter the same fixture directory during a test. If the tests run concurrently, it's likely the weights.h5 file will be removed by the first before the second is done with it.
This PR adds a fixture helper that'll give each test a unique copy of a fixture that gets cleaned up automatically. I only updated the flakey tests, but this is probably good to add to the rest since things like
.cog
temp dirs often linger as well.