In event of error, check equality #2415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When checking if 2 version strings are greater or equal, if an error occurs parsing the version fall back to string equality instead of panicking
aron
reviewed
Jun 17, 2025
aron
requested changes
Jun 17, 2025
There was a problem hiding this comment.
Sorry, I'm still not sure this is doing what we need it to do. To be clear if a user project provides a version range then we need to ensure that that range is satisfied by the explicit version pinned in the requirements we get from the CDN.
Some examples of this would be:
replicate==1.0.0
replicate>=1.0.0b1
replicate>=1.0.0b1,<2.0.0a1
It's important to note that Python does not use SemVer, instead it uses it's own syntax defined in pep440 and implemented in the packaging module.
aron
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fall back to string equality instead of panicking