Fix for branch protection rules + dynamic matrix jobs #2353
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue in branch protection rules by introducing a new meta job that aggregates results from multiple test jobs.
- Introduces a new meta job "Test Results" that depends on "test-go", "test-python", and "test-integration".
- Updates the workflow to consolidate test outcomes and better align with branch protection checks.
Comments suppressed due to low confidence (1)
.github/workflows/ci.yaml:58
- Consider renaming the job id from 'test' to 'test-results' to improve clarity and better align with its display name 'Test Results'.
test:
Happy to make the update as soon as this has landed. |
|
@tempusfrangit this has been merged! |
|
@michaeldwan protection rules have been updated. - please verify they are working as you expect |
I ran into an issue over in #2327 where branch protection rules will never pass when referring to matrix jobs.
The rule requires a check named
"Test Integration"to be successful, but after making that GHA job a matrix, names are now"Test Integration (matrix-param)", which obviously won't match.This PR adds a new meta job named "Test Results" which depends on the integration matrix job, as well as the other tests that were probably not required because of the same issue.
@tempusfrangit once this is merged can you change the required check name to "Test Results"?