Skip to content

Conversation

michaeldwan
Copy link
Member

@michaeldwan michaeldwan commented May 13, 2025

This replaces the docker.ManifestInspect function, which called docker manifest inspect, with a registry client decoupled from the daemon. The current usage is pretty much checking if a manifest exists (to determine if a r8 model exists) but we need registry manipulation for an upcoming PR, so here's a starting point.

Also adds

  • a test helper for booting a registry in tests that's preloaded with a handful of images
  • a utility to initialize a registry storage from scratch with a predefined set of images

- Helper for running a local registry w/ preloaded images in test environments.
- util for loading a set of predefined images into a clean registry storage
- update a few tests to use the test registry helper
for now... GHA doesn't have rootless docker and i don't want to debug that now
@michaeldwan michaeldwan requested review from a team and 8W9aG May 13, 2025 19:57
@michaeldwan michaeldwan merged commit 4c8b448 into main May 13, 2025
38 of 39 checks passed
@michaeldwan michaeldwan deleted the md/docker-client-registry branch May 13, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants