Skip to content

Include sha256: prefix in generated runtime config files #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

meatballhat
Copy link
Contributor

Since all previous runtime configs include the sha256: prefix expected by other components in the whole thing.

Connected to PLAT-848

@meatballhat meatballhat requested a review from a team February 14, 2025 22:34
Copy link
Contributor

@NikhilSinha1 NikhilSinha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think overriding the json.Marshal is a potential future optimization but eh don't care rn

@meatballhat meatballhat merged commit e12f237 into main Feb 15, 2025
21 checks passed
@meatballhat meatballhat deleted the include-sha256-prefix branch February 15, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants