Skip to content

Enforce usage of r8.im image name #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 11, 2025
Merged

Enforce usage of r8.im image name #2146

merged 7 commits into from
Feb 11, 2025

Conversation

8W9aG
Copy link
Contributor

@8W9aG 8W9aG commented Feb 11, 2025

  • Do not use the username from the authentication credentials, the user could always push to an org
    that they have access to.
  • Make sure the URL is a r8.im URL before breaking it up.

* Do not use the username from the authentication
credentials, the user could always push to an org
that they have access to.
* Make sure the URL is a r8.im URL before breaking
it up.
@8W9aG 8W9aG requested review from meatballhat, nevillelyh, NikhilSinha1 and a team February 11, 2025 17:53
@8W9aG 8W9aG requested a review from erbridge February 11, 2025 18:04
Co-authored-by: F <f@replicate.com>
Signed-off-by: Will Sackfield <will.sackfield@gmail.com>
Co-authored-by: F <f@replicate.com>
Signed-off-by: Will Sackfield <will.sackfield@gmail.com>
@8W9aG 8W9aG requested a review from erbridge February 11, 2025 18:06
Co-authored-by: F <f@replicate.com>
Signed-off-by: Will Sackfield <will.sackfield@gmail.com>
@8W9aG 8W9aG requested a review from erbridge February 11, 2025 18:08
@8W9aG 8W9aG merged commit 59545cc into main Feb 11, 2025
21 checks passed
@8W9aG 8W9aG deleted the sackfield/enforce-r8.im-urls branch February 11, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants