Create multipart uploader for fast push #2135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikhil Sinha <nikhil@replicate.com>
Signed-off-by: Nikhil Sinha <nikhil@replicate.com>
…ultipart-uploader Signed-off-by: Nikhil Sinha <nikhil@replicate.com>
Signed-off-by: Nikhil Sinha <nikhil@replicate.com>
Signed-off-by: Nikhil Sinha <nikhil@replicate.com>
Signed-off-by: Nikhil Sinha <nikhil@replicate.com>
Signed-off-by: Nikhil Sinha <nikhil@replicate.com>
meatballhat
approved these changes
Feb 11, 2025
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return &manifest, nil | ||
| return &manifests[0], nil // Docker inspect returns us a list of manifests |
There was a problem hiding this comment.
probably worth checking the len(manifests) and returning a non-nil err if it is empty rather than potentially panicking here
pkg/web/client.go
Outdated
| @@ -102,19 +108,19 @@ func (c *Client) PostNewVersion(ctx context.Context, image string, weights []Fil | |||
| func (c *Client) versionFromManifest(image string, weights []File, files []File) (*Version, error) { | |||
| manifest, err := c.dockerCommand.Inspect(image) | |||
| if err != nil { | |||
| return nil, err | |||
| return nil, fmt.Errorf("failed to inspect docker image: %v", err) | |||
There was a problem hiding this comment.
make sure to use fmt.Errorf with %w instead of %v so that the error is wrapped instead of stringified
tools/uploader/s3.go
Outdated
Comment on lines
65
to
66
| // 64 GB default limit | ||
| uploader.MaxPartUploads = util.GetEnvOrDefault(UPLOADER_MAX_PARTS_UPLOAD_KEY, 1024*4, parseInt32) |
There was a problem hiding this comment.
What is the 64 GB referencing here in the comment?
tools/uploader/s3.go
Outdated
| func (s *s3Uploader) Initialize() { | ||
| if !s.initialized { | ||
| s.mpuBufferPool = sync.Pool{ | ||
| New: func() interface{} { |
There was a problem hiding this comment.
prefer any over interface{} 🎉
tools/uploader/s3.go
Outdated
Comment on lines
158
to
161
| // Initialize if we haven't already | ||
| if !s.initialized { | ||
| s.Initialize() | ||
| } |
There was a problem hiding this comment.
IIUC this should be safe, right?
Suggested change
| // Initialize if we haven't already | |
| if !s.initialized { | |
| s.Initialize() | |
| } | |
| s.Initialize() |
Signed-off-by: Nikhil Sinha <nikhil@replicate.com>
Signed-off-by: Nikhil Sinha <nikhil@replicate.com>
…ultipart-uploader Signed-off-by: Nikhil Sinha <nikhil@replicate.com>
Signed-off-by: Nikhil Sinha <nikhil@replicate.com>
Signed-off-by: Nikhil Sinha <nikhil@replicate.com>
Signed-off-by: Nikhil Sinha <nikhil@replicate.com>
Signed-off-by: Nikhil Sinha <nikhil@replicate.com>
Signed-off-by: Nikhil Sinha <nikhil@replicate.com>
…ultipart-uploader Signed-off-by: Nikhil Sinha <nikhil@replicate.com>
Signed-off-by: Nikhil Sinha <nikhil@replicate.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are having loads of problems with the AWS managed uploader so let's replace it with a different managed uploader that we have more control over.
Test Plan
I tested this using the following script:
Insert your username in
test-integration/test_integration/fixtures/fast-buildso that the image line withimage: r8.im/<R8_USERNAME>/testsays your username instead of<R8_USERNAME>And also don't forget to create the model
testin Replicate web for your username!This set of commands should succeed